I asked that question of myself a while ago! It actually depends on what's the highest selling item on the market, since clovers might just be less value than anything else.

For example, a while ago i was wondering if it would be more worth it to sell blueberries or another plant since each was 15-20 apiece, and it did actually come up that if you can sell them at that price, it's probably just better to grow other things and sell the pieces individually (Sprouts for 15 per, lucky beans for whatever, clovers for 15/pc) or sell something of higher value instead of clovers, and also open up other options for yourself.

The main problem is the low yield of clovers (1 per harvest), and you need 2 to make the potion, and lucky beans, which are entirely dependent on... well, luck. I recently went through about 10 dragonfruit, and got maybe 3 lucky beans out of it?

Lower levelled pets would be more likely to get lucky beans, but the grade would be lower, so yeah...

Right now, I find them still worth because currently clovers are 15-ish on the market, with a 24hr growth rate, so they're good to sell. They're also good for getting low levelled pets up in exp quick, but other than that wealth potions are a little bogged down with problems.

They are still a good source of steady income-- if you actually have the clovers. It's just the beans that really give trouble, I feel. They're way too hard to get. I get that wealth potions are the easiest recipe and probably the go-to for newbies, but yeah, the beans are... a bit iffy, I think? If you can't find them, you can't make the potions unless you buy them, and lucky beans aren't that cheap on the auction market last I checked, because they're a bit unreliable to find. They also require an entirely different plant to even get (dragonfruit), which is troublesome when the starter house has only 2 plant pots, so either you wait 2 days for 2 clovers or buy the dragonfruit at a chance for lucky beans.

EDIT: 31/2/2019 I just checked, the only lucky bean on the auction market is 25pc, which really isn't worth making a wealth potion with since that's already half the price...